Minor cleanups from a staticcheck pass#366
Merged
Merged
Conversation
- Check previously dropped errors from NewIndexSeed and GetStoreOptionsFor in tests, which could have masked test failures - SFTPStore.RemoveChunk no longer reports connection or permission errors from Stat as ChunkMissing, only actual missing files - Remove the unused DedupQueue.mu and fileSeedSegment.needValidation fields - Simplify the append loop in NewStoreRouter - Lowercase two error strings in cmd/desync/store.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A collection of small fixes surfaced by staticcheck and review;
staticcheck ./...is clean after this.assemble_test.goignored the error fromNewIndexSeed(), andcmd/desync/options_test.goignored the error from the firstGetStoreOptionsFor()call in two tests (SA4006). These could have masked failures.SFTPStore.RemoveChunkerror mapping: anyStatfailure — including connection or permission errors — was reported asChunkMissing. Only map actual not-found errors; return everything else as-is. This matters forverify -repairagainst an SFTP store, where a dropped connection previously looked like a missing chunk.DedupQueue.mu(the real locking lives in the innerqueuetype) andfileSeedSegment.needValidation(U1000).append(l, stores...)(S1011), lowercase two error strings (ST1005).