Fix LocalStore.GetChunk dropping read errors#363
Merged
Conversation
Any error from os.ReadFile other than "file does not exist" - permission problems, I/O errors, truncated reads - was silently ignored and the nil or partial buffer handed to NewChunkFromStorage. With verification enabled the caller saw a misleading ChunkInvalid instead of the real error, and with SkipVerify set the store returned a chunk holding partial data with no error at all. Return the underlying error instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LocalStore.GetChunk()only checked the error fromos.ReadFilewithos.IsNotExist(). Any other read failure — permission problems, I/O errors, truncated reads — was silently ignored and the nil or partial buffer handed toNewChunkFromStorage():ChunkInvalidinstead of the real error (and aRepairableCachewould then treat it as missing and re-fetch, hiding e.g. a permission problem indefinitely).SkipVerifyset (--skip-verify, or thepullcommand), the store returned a chunk holding partial data with no error at all.Return the underlying error instead. The new test uses a directory in place of the chunk file to trigger a non-
IsNotExistread error on all platforms; it fails against the previous code (returned a bogus chunk with nil error underSkipVerify).