Skip to content

Fix GCS not-found detection to unwrap ErrObjectNotExist (#358) #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
folbricht merged 1 commit into from
Jun 18, 2026
Merged

Fix GCS not-found detection to unwrap ErrObjectNotExist (#358) #359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions gcs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ func (s GCStore) GetChunk(id ChunkID) (*Chunk, error) {

rc, err := s.client.Object(name).NewReader(ctx)

if err == storage.ErrObjectNotExist {
if errors.Is(err, storage.ErrObjectNotExist) {
log.Warning("Unable to create reader for object in GCS bucket; the object may not exist, or the bucket may not exist, or you may not have permission to access it")
return nil, ChunkMissing{ID: id}
} else if err != nil {
Expand All @@ -116,7 +116,7 @@ func (s GCStore) GetChunk(id ChunkID) (*Chunk, error) {

b, err := io.ReadAll(rc)

if err == storage.ErrObjectNotExist {
if errors.Is(err, storage.ErrObjectNotExist) {
log.Warning("Unable to read from object in GCS bucket; the object may not exist, or the bucket may not exist, or you may not have permission to access it")
return nil, ChunkMissing{ID: id}
} else if err != nil {
Expand Down Expand Up @@ -184,7 +184,7 @@ func (s GCStore) HasChunk(id ChunkID) (bool, error) {

_, err := s.client.Object(name).Attrs(ctx)

if err == storage.ErrObjectNotExist {
if errors.Is(err, storage.ErrObjectNotExist) {
log.WithField("exists", false).Debug("Chunk does not exist in GCS bucket")
return false, nil
} else if err != nil {
Expand Down