[Executor] Update taskaction cr #6826
Draft
+506
−145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
Based on the k8s api convention (here), it mentioned:
It's better for us to remove Phase and Message and just use Conditions in our executor to follow the best practice.
What changes were proposed in this pull request?
Controller changes:
Conditionsfor the reconcile logic, following best practice mentioned in api-conventionsSucceed,Failed,Progressing). UseReasonfor status detailSpec, and update sample YAMLkubebuilder:printcolumnfor observabilityDevelopment Changes:
go.mod,Dockerfile, andMakefileto buildexecutorsuccessfullyDEVELOPMENT.mdto guide through setting up local development environment and apply examplesHow was this patch tested?
DEVELOPMENT.mdfor setup and apply example withkubectl apply -k config/samples/. Ensure the conditions change correctly❯ k describe taskactions taskaction-sample Name: taskaction-sample Namespace: default Labels: app.kubernetes.io/managed-by=kustomize app.kubernetes.io/name=executor Annotations: <none> API Version: flyte.org/v1 Kind: TaskAction Metadata: Creation Timestamp: 2025-12-30T02:22:35Z Generation: 1 Resource Version: 991 UID: 12fa6800-91de-4b11-9501-66b4ebd43df6 Spec: Action Name: sample-task Domain: dev Input Uri: /tmp/input Org: demo Project: default Run Name: sample-run Run Output Base: /tmp/output Status: Conditions: Last Transition Time: 2025-12-30T02:26:47Z Message: TaskAction has completed Reason: Completed Status: False Type: Progressing Last Transition Time: 2025-12-30T02:26:47Z Message: TaskAction completed successfully Reason: Completed Status: True Type: Succeeded State Json: {"actionId":"sample-run/sample-task","phase":"Succeeded","timestamp":"2025-12-30T02:26:47Z"} Events: <none>Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link