Skip to content

Conversation

@Sovietaced
Copy link
Member

Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Labels

Please add one or more of the following labels to categorize your PR:

  • added: For new features.
  • changed: For changes in existing functionality.
  • deprecated: For soon-to-be-removed features.
  • removed: For features being removed.
  • fixed: For any bug fixed.
  • security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@flyte-bot
Copy link
Collaborator

Bito Automatic Review Skipped - Draft PR

Bito didn't auto-review because this pull request is in draft status.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change draft PR review settings here, or contact your Bito workspace admin at [email protected].

@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

❌ Patch coverage is 52.80000% with 59 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.92%. Comparing base (55568e0) to head (1cbc176).

Files with missing lines Patch % Lines
datacatalog/pkg/rpc/datacatalogservice/service.go 0.00% 8 Missing ⚠️
flytepropeller/events/admin_eventsink.go 0.00% 8 Missing ⚠️
flyteadmin/pkg/server/service.go 0.00% 5 Missing ⚠️
...ontroller/nodes/catalog/datacatalog/datacatalog.go 0.00% 5 Missing ⚠️
...tepropeller/pkg/controller/nodes/branch/handler.go 33.33% 4 Missing ⚠️
...er/pkg/controller/nodes/task/future_file_reader.go 0.00% 4 Missing ⚠️
flytepropeller/pkg/visualize/visualize.go 0.00% 4 Missing ⚠️
...peller/pkg/controller/workflowstore/passthrough.go 0.00% 2 Missing and 1 partial ⚠️
...luginmachinery/ioutils/remote_file_input_reader.go 0.00% 2 Missing ⚠️
...gins/go/tasks/plugins/array/awsbatch/task_links.go 0.00% 2 Missing ⚠️
... and 12 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6771      +/-   ##
==========================================
+ Coverage   56.91%   56.92%   +0.01%     
==========================================
  Files         929      929              
  Lines       58081    58084       +3     
==========================================
+ Hits        33055    33063       +8     
+ Misses      21985    21984       -1     
+ Partials     3041     3037       -4     
Flag Coverage Δ
unittests-datacatalog 53.51% <0.00%> (ø)
unittests-flyteadmin 53.02% <0.00%> (+<0.01%) ⬆️
unittests-flytecopilot 43.16% <ø> (ø)
unittests-flytectl 64.06% <ø> (+0.03%) ⬆️
unittests-flyteidl 75.71% <ø> (ø)
unittests-flyteplugins 60.16% <74.07%> (+0.01%) ⬆️
unittests-flytepropeller 53.55% <54.11%> (+<0.01%) ⬆️
unittests-flytestdlib 63.29% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@flyte-bot
Copy link
Collaborator

Bito Automatic Review Skipped - Draft PR

Bito didn't auto-review because this pull request is in draft status.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change draft PR review settings here, or contact your Bito workspace admin at [email protected].

@flyte-bot
Copy link
Collaborator

Bito Automatic Review Skipped - Draft PR

Bito didn't auto-review because this pull request is in draft status.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change draft PR review settings here, or contact your Bito workspace admin at [email protected].

@flyte-bot
Copy link
Collaborator

Bito Automatic Review Skipped - Draft PR

Bito didn't auto-review because this pull request is in draft status.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change draft PR review settings here, or contact your Bito workspace admin at [email protected].

Signed-off-by: Jason Parraga <[email protected]>
Signed-off-by: Jason Parraga <[email protected]>
Signed-off-by: Jason Parraga <[email protected]>
Signed-off-by: Jason Parraga <[email protected]>
Signed-off-by: Jason Parraga <[email protected]>
@flyte-bot
Copy link
Collaborator

Bito Automatic Review Skipped - Draft PR

Bito didn't auto-review because this pull request is in draft status.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change draft PR review settings here, or contact your Bito workspace admin at [email protected].

Signed-off-by: Jason Parraga <[email protected]>
Signed-off-by: Jason Parraga <[email protected]>
Signed-off-by: Jason Parraga <[email protected]>
@flyte-bot
Copy link
Collaborator

Bito Automatic Review Skipped - Draft PR

Bito didn't auto-review because this pull request is in draft status.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change draft PR review settings here, or contact your Bito workspace admin at [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants