Skip to content

Standardize on async I/O and waiting for work to complete #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ linter:
- test_types_in_equals
- throw_in_finally
- type_init_formals
- unawaited_futures
- unnecessary_brace_in_string_interps
- unnecessary_const
- unnecessary_getters_setters
Expand Down
8 changes: 4 additions & 4 deletions lib/abs/icon_generator.dart
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ abstract class IconGenerator {
IconGenerator(this.context, this.platformName);

/// Creates icons for this platform.
void createIcons();
Future<void> createIcons();

/// Should return `true` if this platform
/// has all the requirements to create icons.
Expand Down Expand Up @@ -67,13 +67,13 @@ class IconGeneratorContext {
}

/// Generates Icon for given platforms
void generateIconsFor({
Future<void> generateIconsFor({
required Config config,
required String? flavor,
required String prefixPath,
required FLILogger logger,
required List<IconGenerator> Function(IconGeneratorContext context) platforms,
}) {
}) async {
try {
final platformList = platforms(
IconGeneratorContext(
Expand Down Expand Up @@ -103,7 +103,7 @@ void generateIconsFor({
progress.cancel();
continue;
}
platform.createIcons();
await platform.createIcons();
progress.finish(message: 'done', showTiming: true);
} catch (e, st) {
progress.cancel();
Expand Down
Loading