Skip to content

output: add metrics for dropped oldest chunk count #4981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025

Conversation

Watson1978
Copy link
Contributor

@Watson1978 Watson1978 commented May 28, 2025

Which issue(s) this PR fixes:
Fixes #

What this PR does / why we need it:
When overflow_action drop_oldest_chunk is configured, the oldest buffer chunk will be automatically discarded when the total buffer capacity is exhausted.

This PR introduces a new metric, drop_oldest_chunk_count, which counts the number of discarded chunks.

Docs Changes:
fluent/fluentd-docs-gitbook#582

Release Note:
Same as the title

@Watson1978 Watson1978 force-pushed the drop_oldest_chunk_count branch 2 times, most recently from f18bd12 to 285563b Compare May 29, 2025 01:57
@Watson1978 Watson1978 force-pushed the drop_oldest_chunk_count branch from 285563b to e0be8f9 Compare May 29, 2025 06:09
@Watson1978 Watson1978 marked this pull request as ready for review May 29, 2025 06:46
@Watson1978 Watson1978 requested a review from daipom May 29, 2025 09:39
@daipom daipom added this to the v1.19.0 milestone Jun 2, 2025
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@daipom daipom merged commit e5c1623 into fluent:master Jun 2, 2025
24 of 25 checks passed
@Watson1978 Watson1978 deleted the drop_oldest_chunk_count branch June 3, 2025 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants