Skip to content

in_tail: add "tracked_file_count" metrics to see how many log files are being tracked #4980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

Watson1978
Copy link
Contributor

@Watson1978 Watson1978 commented May 28, 2025

Which issue(s) this PR fixes:
Fixes #

What this PR does / why we need it:
This PR will add a tracked_file_count field to the value returned by statistics method.
This will make it easy to see how many log files are being tracked.

Docs Changes:
It appears that there is no documentation at all on plugin-specific metrics.
Maybe we should add document about in_tail's metrics to https://docs.fluentd.org/input/tail.

Release Note:
Same as the title.

@Watson1978 Watson1978 force-pushed the add-metrics-into-in_tail branch 2 times, most recently from 2e5fac2 to 5cb8d66 Compare May 28, 2025 08:34
@Watson1978 Watson1978 marked this pull request as ready for review May 28, 2025 10:07
@Watson1978 Watson1978 requested a review from daipom May 29, 2025 00:55
@Watson1978 Watson1978 force-pushed the add-metrics-into-in_tail branch from 5cb8d66 to fb40927 Compare May 29, 2025 01:32
@kenhys
Copy link
Contributor

kenhys commented Jun 2, 2025

MEMO: It was discussed about reducing tracked_file_metrics setting call. simplify to call it in the watcher updating case.

@Watson1978 Watson1978 force-pushed the add-metrics-into-in_tail branch from fb40927 to efed7be Compare June 2, 2025 04:11
@daipom daipom added this to the v1.19.0 milestone Jun 3, 2025
@daipom daipom changed the title in_tail: add metrics for file tracked count in_tail: add "tracked_file_count" metrics to see how many log files are being tracked Jun 3, 2025
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@daipom daipom merged commit e42097b into fluent:master Jun 3, 2025
13 checks passed
@Watson1978 Watson1978 deleted the add-metrics-into-in_tail branch June 3, 2025 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants