-
Notifications
You must be signed in to change notification settings - Fork 20
Add socket receive buffer size configuration #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @DineshI-MS Looking more at this approach. It might be easier to just provide an API to set the receiver buffer: This would redude the complexity of configuration and would also users allow to change it any time. Would you be open to update your PR with such an approach?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for providing this suggestion. I was able to set the buffer size this way without making any additional changes. I wasn’t aware of the API functions that are already part of
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @DineshI-MS Would you be open to update your PR with this new approach?
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As Nflog already exposes *netlink.Conn, it might be best to just improve documentation. I might open a new PR in a few days improving documentation, if this PR becomes stale. |
Uh oh!
There was an error while loading. Please reload this page.