Caiman PyTorch -> Ver 1.0.1 #1535
Merged
+247
−159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgunn
reviewed
Nov 5, 2025
demos/notebooks/demo_VST.ipynb
Outdated
| "source": [ | ||
| "if play_movies:\n", | ||
| " movie_gat.play(magnification=4, q_max=99.8)" | ||
| "#if play_movies:\n", |
Member
There was a problem hiding this comment.
I think the play_movies boolean makes commenting out lines like this now unnecessary
pgunn
reviewed
Nov 5, 2025
| "h = cm.concatenate([movie, movie_gat_inv], axis=2)\n", | ||
| "if play_movies:\n", | ||
| " h.play(magnification=5, q_max=99.5)" | ||
| "#if play_movies:\n", |
pgunn
reviewed
Nov 5, 2025
| "source": [ | ||
| "if play_movies:\n", | ||
| " Y[...,5].play(magnification=2)" | ||
| "#if play_movies:\n", |
pgunn
reviewed
Nov 5, 2025
| "downsample_ratio = .2 # motion can be perceived better when downsampling in time\n", | ||
| "m_orig.resize(1, 1, downsample_ratio)", | ||
| "# Set play_movies to false if you want to disable play of movies, e.g. for remote-hosted Jupyter environments\n", | ||
| "m_orig.resize(1, 1, downsample_ratio)# Set play_movies to false if you want to disable play of movies, e.g. for remote-hosted Jupyter environments\n", |
Contributor
Author
There was a problem hiding this comment.
Yes, this was a mistake.
pgunn
reviewed
Nov 5, 2025
| " fr=20, \n", | ||
| " magnification=1, \n", | ||
| " plot_text=True)" | ||
| "#if play_movies:\n", |
pgunn
reviewed
Nov 5, 2025
| " magnification=1,\n", | ||
| " gain=0.6,\n", | ||
| " plot_text=True)\n" | ||
| "#if inspect_results and play_movies:\n", |
pgunn
reviewed
Nov 5, 2025
| " 'motion_correct': True, # flag for performing motion correction\n", | ||
| " 'gSig_filt': (3, 3), # size of high pass spatial filtering, used in 1p data\n", | ||
| " 'use_cnn': False}\n", | ||
| " 'use_cnn': True} #False}\n", |
Member
There was a problem hiding this comment.
no need to have a commented out false; people understand booleans
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Branching
Has your PR been tested?
If you're fixing a bug or introducing a new feature it is recommended you run the tests by typing
caimanmanager testand
caimanmanager demotestprior to submitting your pull request.
Please describe any additional tests that you ran to verify your changes. If they are fast you can also
include them in the folder 'caiman/tests/
and name themtest_***.py` so they can be included in our lists of tests.