remove the option for standard building #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akundaz
requested review from
SozinM,
avalonche and
karim-agha
as code owners
akundaz
force-pushed
the
ak-remove-standard-building
branch
from
4933c58 to
a49c1d9
Compare
julio4
requested changes
Nov 4, 2025
akundaz
force-pushed
the
ak-remove-standard-building
branch
2 times, most recently
from
818857d to
8e0c207
Compare
julio4
approved these changes
Nov 7, 2025
Collaborator
There was a problem hiding this comment.
would it be possible/wise to puts the ws_addr inside the LocalNode<Flashblocks, _> with a getter like node.ws_addr()?
To do like:
let node = Flashblocks::test_node().await?;
let ws_addr = node.ws_addr();its not a big deal so no need to actually implement it
Collaborator
Author
There was a problem hiding this comment.
i'll get around to this in another pr since we don't even have a node type so this will take a bit of code
akundaz
force-pushed
the
ak-remove-standard-building
branch
from
8e0c207 to
3dada55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll only be running with flashblocks