fix flashblock timing #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akundaz
requested review from
SozinM,
avalonche and
karim-agha
as code owners
SozinM
reviewed
Oct 27, 2025
| } | ||
|
|
||
| #[test] | ||
| fn many_flashblocks_with_large_remaining_time() { |
Collaborator
There was a problem hiding this comment.
Can we also add test for zero remaining time?
This happens when FCU arrived later then dealine
Collaborator
Author
There was a problem hiding this comment.
Added. It expects 0 flashblocks and the first flashblock time doesn't really matter since it'll break out
akundaz
force-pushed
the
ak-fix-flashblock-timing
branch
from
d508863 to
7371ca5
Compare
SozinM
reviewed
Oct 27, 2025
| { | ||
| let gas_used = payload.cumulative_gas_used(); | ||
| let remaining_gas = enclosing.gas_limit.saturating_sub(gas_used); | ||
| tracing::warn!( |
Collaborator
There was a problem hiding this comment.
This was super useful log (but should be info, let's bring it back)
Collaborator
Author
There was a problem hiding this comment.
Done, and changed to info
akundaz
force-pushed
the
ak-fix-flashblock-timing
branch
from
d352346 to
089f961
Compare
SozinM
reviewed
Oct 30, 2025
| flashblock_number.clone(), | ||
| )), | ||
| ) | ||
| .with_step(BreakAfterDeadline), |
Collaborator
There was a problem hiding this comment.
Why haven't you combined steps?
Collaborator
Author
There was a problem hiding this comment.
I tried but it ended up breaking a couple tests
SozinM
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor and fix flashblock timing
partition_time_into_flashblocksto calculate the first flashblock time and number of flashblocks and unit test it throughly.BreakAfterMaxFlashblocksto stop once we hit the maximum number of flashblocksThe new tests all pass, some old ones are still broken.
Also tested with builder-playground and fbutil and flashblocks are being produced at the right time:
Occasionally flashblocks without a base will be produced but that seems out-of-scope for this PR.