write builder tx in flashblocks #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akundaz
requested review from
SozinM,
avalonche and
karim-agha
as code owners
SozinM
reviewed
Oct 15, 2025
src/main.rs
Outdated
| let flashblock_building_pipeline_steps = | ||
| if let Some(ref signer) = cli_args.builder_signer { | ||
| flashblock_building_pipeline_steps | ||
| .with_step(BuilderEpilogue::with_signer(signer.clone().into())) |
Collaborator
There was a problem hiding this comment.
will it work that way? won't you add a lot of builder transaciton? I think it must be epilogue
Collaborator
There was a problem hiding this comment.
yeah
🔗 Block #35 16:19:42.463
- ⚡ 0, gas: 3.5M/60.0M (5.8%), 1 txs +399 ms +0.0 (0.0%) gas
- ⚡ 1, gas: 6.0M/60.0M (10.1%), 120 txs +201 ms +2.6M (4.3%) gas
- ⚡ 2, gas: 8.1M/60.0M (13.6%), 98 txs +203 ms +2.1M (3.5%) gas
- ⚡ 3, gas: 10.0M/60.0M (16.7%), 88 txs +202 ms +1.9M (3.1%) gas
- ⚡ 4, gas: 10.1M/60.0M (16.8%), 3 txs +1 ms +64.2K (0.1%) gas
Collaborator
Author
There was a problem hiding this comment.
we should be able to check this in tests
SozinM
reviewed
Oct 16, 2025
akundaz
force-pushed
the
ash-tottssqxtomy
branch
from
7104ace to
5147e8c
Compare
akundaz
force-pushed
the
ash-tottssqxtomy
branch
from
5147e8c to
2b5383f
Compare
akundaz
force-pushed
the
ash-tottssqxtomy
branch
from
2b5383f to
5c35e5c
Compare
SozinM
approved these changes
Oct 17, 2025
Collaborator
|
LGTM feel free to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just added the
BuilderEpilogueto the flashblocks pipelineAlso cleaned up some things along the way