-
Notifications
You must be signed in to change notification settings - Fork 67
[breaking-change] Improve ping/pong logic #422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SozinM
wants to merge
11
commits into
main
Choose a base branch
from
msozin/fix-pongs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
does it have any backwards compatibility issues? |
Have you looked at the https://github.com/Xuanwo/backon crate? It's more ergonomic and seems to be actively maintained |
avalonche
reviewed
Oct 14, 2025
would be good to add integration tests |
avalonche
reviewed
Oct 15, 2025
avalonche
reviewed
Oct 15, 2025
avalonche
reviewed
Oct 15, 2025
avalonche
approved these changes
Oct 15, 2025
akundaz
reviewed
Oct 15, 2025
noot
reviewed
Oct 15, 2025
noot
reviewed
Oct 15, 2025
noot
reviewed
Oct 15, 2025
noot
reviewed
Oct 15, 2025
7e6b839
to
a17d0e0
Compare
akundaz
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains breaking changes!
--flashblock-builder-ws-reconnect-ms was changed, now it consists of 2 params:
--flashblock-builder-ws-initial-reconnect-ms and --flashblock-builder-ws-max-reconnect-ms that are used in explonential backoff with multiplier 1.5 (timeout increased by 50% every unsuccessful reconnections and reset on successful connection)
--flashblock-builder-ws-ping-interval-ms - how often send pings
--flashblock-builder-ws-pong-timeout-ms - timeout for pong. If we haven't receive pong for ping that we send for timeout - close connection.