Add Support for Library Mode #420
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
teddyknox
force-pushed
the
push-uksuovvzmmus
branch
3 times, most recently
from
983e29b to
a5b5b85
Compare
crates/rollup-boost/src/metrics.rs
Outdated
| @@ -1,22 +1,38 @@ | |||
| #[cfg(all(feature = "server", feature = "metrics-exporter-prometheus"))] | |||
There was a problem hiding this comment.
are you gating the whole file behind the server feature? if so declaring this once at the top should work
There was a problem hiding this comment.
I was yes, but I am now proposing that we not to introduce a new feature to differentiate between server and library components. Instead, I'd like to propose they both are exposed by the same crate and feature. Is this OK?
| } | ||
| } | ||
|
|
||
| #[cfg(feature = "server")] |
There was a problem hiding this comment.
Do we really need to feature gate tests?
I expect that all tests would be run with default features (which should include server)
There was a problem hiding this comment.
Agreed. Removing all feature gating that I had introduced before.
|
TBH i feel that we need more in-depth split of binary-library |
teddyknox
force-pushed
the
push-uksuovvzmmus
branch
from
a5b5b85 to
a26d554
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR implements library mode functionality for rollup-boost, enabling direct integration into Rust applications while maintaining backward compatibility with existing server deployments. The changes introduce a structured configuration system and feature flag support to allow both server and library usage patterns.
- Adds
RollupBooststruct with builder pattern configuration for library use - Refactors client configuration through centralized
ClientArgsstruct - Implements feature flag system separating server and library functionality
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/websocket-proxy/Cargo.toml | Adds integration feature flag |
| crates/rollup-boost/src/server.rs | Refactors server to use trait objects and adds factory method |
| crates/rollup-boost/src/proxy.rs | Simplifies proxy layer to accept pre-built HTTP clients |
| crates/rollup-boost/src/flashblocks/args.rs | Adds Default implementation for FlashblocksArgs |
| crates/rollup-boost/src/client/rpc.rs | Introduces ClientArgs struct with factory methods |
| crates/rollup-boost/src/cli.rs | Refactors CLI to use new ClientArgs pattern |
| crates/rollup-boost/Cargo.toml | Updates reth-rpc-layer dependency version |
| Cargo.toml | Updates reth-optimism-payload-builder dependency version |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
teddyknox
force-pushed
the
push-uksuovvzmmus
branch
from
a26d554 to
94b7ccb
Compare
* unify client configuration with ClientArgs struct * Consolidate BuilderArgs/L2ClientArgs into unified ClientArgs pattern * Move JWT handling into ClientArgs with helper methods * Update ProxyLayer to accept HttpClient instances instead of raw config * Add RollupBoostServer::new_from_args for cleaner initialization * Bump reth-rpc-layer to v1.8.2
teddyknox
force-pushed
the
push-uksuovvzmmus
branch
from
94b7ccb to
e9ee917
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 9 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| // health_check_interval: 60, | ||
| // max_unsafe_interval: 10, | ||
| // rpc_host: "127.0.0.1".to_string(), | ||
| // rpc_port: 8081, | ||
| // tracing: false, | ||
| // metrics: false, | ||
| // metrics_host: "127.0.0.1".to_string(), | ||
| // metrics_port: 9090, | ||
| // otlp_endpoint: "http://localhost:4317".to_string(), | ||
| // log_level: Level::INFO, | ||
| // log_format: LogFormat::Text, | ||
| // log_file: None, | ||
| // debug_host: "127.0.0.1".to_string(), | ||
| // debug_server_port: 5555, | ||
| // execution_mode: ExecutionMode::Enabled, | ||
| // block_selection_policy: None, | ||
| // external_state_root: false, | ||
| // ignore_unhealthy_builders: false, | ||
| // flashblocks: FlashblocksArgs::default(), | ||
| // } | ||
| // } | ||
| // } |
There was a problem hiding this comment.
This commented-out code should be removed as it adds no value and clutters the codebase.
| // health_check_interval: 60, | |
| // max_unsafe_interval: 10, | |
| // rpc_host: "127.0.0.1".to_string(), | |
| // rpc_port: 8081, | |
| // tracing: false, | |
| // metrics: false, | |
| // metrics_host: "127.0.0.1".to_string(), | |
| // metrics_port: 9090, | |
| // otlp_endpoint: "http://localhost:4317".to_string(), | |
| // log_level: Level::INFO, | |
| // log_format: LogFormat::Text, | |
| // log_file: None, | |
| // debug_host: "127.0.0.1".to_string(), | |
| // debug_server_port: 5555, | |
| // execution_mode: ExecutionMode::Enabled, | |
| // block_selection_policy: None, | |
| // external_state_root: false, | |
| // ignore_unhealthy_builders: false, | |
| // flashblocks: FlashblocksArgs::default(), | |
| // } | |
| // } | |
| // } |
Copilot uses AI. Check for mistakes.
3 participants
This PR consolidates the client configuration pattern across the codebase by introducing a unified
ClientArgsstruct that replaces the separateBuilderArgsandL2ClientArgshandling.Changes
Core refactoring:
ClientArgsstruct with unified JWT secret handlingBuilderArgs/L2ClientArgstoClientArgsClientArgswithnew_rpc_client()andnew_http_client()methodsAPI improvements:
ProxyLayerconstructor to accept pre-configuredHttpClientinstances instead of raw configurationRollupBoostServer::new_from_args()for cleaner server initialization from CLI argsClientArgs::get_auth_jwt()Benefits
ClientArgspatternTesting
All existing tests have been updated to use the new
ClientArgspattern and continue to pass.