First flashblocks integration test #337
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
| .with_log_consumer(builder_log_consumer) | ||
| .start() | ||
| .await?; | ||
| let builder = if self.flashblocks { |
There was a problem hiding this comment.
This is not ideal to me what I wanted to keep the difference between the normal non-flashblocks cycle which can use Reth and the flashblocks protocol which must use op-rbuilder (or any flashblocks enabled builder)
| .build() | ||
| .await?; | ||
| let mut block_generator = harness.block_generator().await?; | ||
| block_generator.generate_builder_blocks(10).await?; |
There was a problem hiding this comment.
this test doesn't make assertions if flashblocks are being built - I think you can make assertions by querying rollup-boost metrics
There was a problem hiding this comment.
It does, internally the function checks whether the block was built by the builder
There was a problem hiding this comment.
yes but it doesn't distinguish between whether its a flashblock or a fallback builder block from get_payload.
There was a problem hiding this comment.
you could assert that source = builder and get_payload method is never called. Unless the purpose of the test is just to ensure the flashblocks flow returns any builder block?
2 participants
This PR introduces the initial integration test for flashblocks functionality. It is using a pinned version of the flashbots
op-rbuildersince it is the only implementation available for the protocol and hence considered the default one as of now.