-
Notifications
You must be signed in to change notification settings - Fork 41
Flashblocks rebase #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
avalonche
wants to merge
24
commits into
main
Choose a base branch
from
flashblocks-rebase
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Flashblocks rebase #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* deps: alloy 0.12.5 * fix reth dep * lint
- Added gas_delta and tx_count_delta to payload metrics in get_payload_v3 and get_payload_v4. - Updated MetricsSpanProcessor to include INVALID_PAYLOAD tracking. - Refactored error handling in RpcClient to log invalid payloads instead of incrementing counters directly.
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
ef2d5b9
to
91cc706
Compare
91cc706
to
73fdd14
Compare
ferranbt
reviewed
May 20, 2025
SozinM
reviewed
May 20, 2025
}; | ||
|
||
let mut clients = self.clients.lock().await; | ||
clients.retain_mut(|sink| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we tested this part with 100/1000 clients, will it have problems because of blocking?
Add error for parsing problems Add Error type for malformed flashblocks
…drawals_root-fix Make withdrawals_root optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase from main for #98.
Adds extra docs and isthmus support.