Restructure the repo as a workspace #233
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
| rustls::crypto::ring::default_provider() | ||
| .install_default() | ||
| .expect("Failed to install TLS ring CryptoProvider"); | ||
| let _ = rustls::crypto::ring::default_provider().install_default(); |
There was a problem hiding this comment.
Same as with the other changes. It fails if you try to install twice.
There was a problem hiding this comment.
would have a warning log here instead of a silent failure
| @@ -242,7 +244,7 @@ impl RollupBoostTestHarnessBuilder { | |||
| let timestamp = dt.format(&format)?; | |||
|
|
|||
| let dir = PathBuf::from(env!("CARGO_MANIFEST_DIR")) | |||
| .join("integration_logs") | |||
| .join("../../integration_logs") | |||
There was a problem hiding this comment.
I like to have the logs on the root folder.
| @@ -42,8 +45,6 @@ impl Default for RollupBoostConfig { | |||
| &format!("--l2-jwt-path={}/jwt_secret.hex", *TEST_DATA), | |||
| &format!("--builder-jwt-path={}/jwt_secret.hex", *TEST_DATA), | |||
| "--log-level=trace", | |||
| "--tracing", | |||
There was a problem hiding this comment.
why are tracing / metrics args removed?
There was a problem hiding this comment.
Tracing can be added back.
Metrics is still done inside rollup-boost and installs a global metric that also panics if It has been registered already.
True! I only thought about the alloy/reth dependencies. I will move the shared ones to the workspace Cargo.toml |
|
does this change how rollup-boost is run within the workspace? please also update the command line docs if so |
Closes #223
I have not changed any internal Rollup-boost logic but on the way we run the integration tests: