fix(ci): enable automatic Docker image publishing on release tags #821
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build-docker job was only running when manually triggered via workflow_dispatch. This change enables automatic Docker image publishing when release tags (v*) are pushed, matching the behavior of the build-binary job. Signed-off-by: falcorocks <[email protected]>
falcorocks
requested review from
ZanCorDX,
dvush,
metachris and
sukoneck
as code owners
Copilot finished reviewing on behalf of
falcorocks
December 1, 2025 16:18
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the release workflow to automatically publish Docker images when release tags are pushed. Previously, Docker images were only built when manually triggered via workflow_dispatch.
Key Changes:
- Updated the
build-dockerjob condition to trigger on tag pushes in addition to manual workflow dispatch
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
build-dockerjob in the release workflow is currently only triggered when manually invoked viaworkflow_dispatchwith thebuild-dockerinput set totrue. This means Docker images are not automatically published when release tags are pushed.Solution
This PR updates the
build-dockerjob condition to match thebuild-binaryjob behavior:Now Docker images will be automatically built and published to
ghcr.io/flashbots/rbuilderwhen release tags (v*) are pushed.