Skip to content

Conversation

noot
Copy link
Contributor

@noot noot commented Oct 16, 2025

📝 Summary

  • add unused_async clippy lint
  • deny unreachable_pub; this previously was not being caught by CI, as it's a rust lint, and the CI was running make lint and only denying on clippy warnings

💡 Motivation and Context

code quality

✅ I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

@noot noot requested review from SozinM and avalonche as code owners October 16, 2025 21:37
@Copilot Copilot AI review requested due to automatic review settings October 16, 2025 21:37
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances code quality by adding stricter linting rules: the unused_async clippy lint to catch unnecessary async functions, and upgrading unreachable_pub from warn to deny to enforce proper visibility modifiers.

  • Added unused_async clippy lint to warn about unnecessary async functions
  • Changed unreachable_pub lint level from warn to deny
  • Removed unnecessary async keyword from generate_genesis function

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
Cargo.toml Added unused_async clippy lint and changed unreachable_pub to deny level
crates/op-rbuilder/src/tests/framework/apis.rs Removed unnecessary async modifier from generate_genesis function

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@noot noot merged commit fa24368 into main Oct 17, 2025
4 checks passed
@noot noot deleted the noot/more-lint branch October 17, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants