Add flashtestation builder tx #282

avalonche · 2025-10-01T22:39:07Z

📝 Summary

Add flashtestations builder tx and registration logic into built block

💡 Motivation and Context

✅ I have completed the following steps:

Run make lint
Run make test
Added tests (if applicable)

crates/op-rbuilder/src/builders/builder_tx.rs

crates/op-rbuilder/src/flashtestations/builder_tx.rs

akundaz · 2025-10-13T20:10:03Z

crates/op-rbuilder/src/flashtestations/builder_tx.rs

+                }
+            }
+        };
+        match result {


it looks like this conversion from the evm result to TxSimulateResult is repeated in simulate_verify_block_proof_tx, can you separate it into another function?

this will be cleaned up in favour of #285

akundaz · 2025-10-13T20:11:06Z

crates/op-rbuilder/src/flashtestations/builder_tx.rs

+        }
+    }
+
+    fn check_verify_block_proof_log(&self, logs: &[Log]) -> bool {


do the iter().any() thing and elide this function since it'll just be a short line then

this is removed in a later PR

But that PR isn't going into main. If we merge this PR then that one later (and I can't predict how much later) then main ends up in a dirty state

I don't think this is a blocking change to merging this PR and #285 is intended to be a fast follow that is going to be run on mainnet. This is preliminary flashtestations code to ensure the whole flow works on experimental

Copilot

Pull Request Overview

Adds flashtestations builder transaction logic (registration and block proof verification) and exposes additional payload context accessors needed for computing block content hashes.

Introduces FlashtestationsBuilderTx with funding, registration, and block proof verification flows.
Adds a new LogMismatch revert reason and a helper constructor BuilderTransactionError::other.
Makes previously internal OpPayloadBuilderCtx accessors public (parent_hash, timestamp, etc.) to support new logic.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
flashtestations/service.rs	Replaces inline stub with instantiation of new FlashtestationsBuilderTx and passes args.
flashtestations/mod.rs	Adds builder_tx module and new LogMismatch revert error variant.
flashtestations/builder_tx.rs	New implementation of funding, registration, and block proof verification logic.
builders/standard/builder_tx.rs	Updates import path for FlashtestationsBuilderTx.
builders/flashblocks/builder_tx.rs	Updates import path and switches to new error helper.
builders/context.rs	Widens visibility of multiple context accessors; adds parent_hash and timestamp helpers.
builders/builder_tx.rs	Adds BuilderTransactionError::other convenience constructor.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-16T18:01:49Z

crates/op-rbuilder/src/flashtestations/builder_tx.rs

+pub struct FlashtestationsBuilderTxArgs {
+    pub attestation: Vec<u8>,
+    pub extra_registration_data: Bytes,
+    pub tee_service_signer: Signer,
+    pub funding_key: Signer,
+    pub funding_amount: U256,
+    pub registry_address: Address,
+    pub builder_policy_address: Address,
+    pub builder_proof_version: u8,
+    pub enable_block_proofs: bool,
+    pub registered: bool,
+}


The registered flag provided in FlashtestationsBuilderTxArgs is never applied; new() always initializes registered with an empty OnceLock, causing the initial known registration status to be ignored and potentially triggering unnecessary registration attempts. Set the OnceLock when args.registered is true, e.g. let mut lock = OnceLock::new(); if args.registered { let _ = lock.set(true); } and assign lock to the struct, or store the initial state separately.

Copilot · 2025-10-16T18:01:49Z

crates/op-rbuilder/src/flashtestations/builder_tx.rs

+impl FlashtestationsBuilderTx {
+    pub fn new(args: FlashtestationsBuilderTxArgs) -> Self {
+        Self {
+            attestation: args.attestation,
+            extra_registration_data: args.extra_registration_data,
+            tee_service_signer: args.tee_service_signer,
+            funding_key: args.funding_key,
+            funding_amount: args.funding_amount,
+            registry_address: args.registry_address,
+            builder_policy_address: args.builder_policy_address,
+            builder_proof_version: args.builder_proof_version,
+            registered: OnceLock::new(),
+            enable_block_proofs: args.enable_block_proofs,
+        }
+    }


The registered flag provided in FlashtestationsBuilderTxArgs is never applied; new() always initializes registered with an empty OnceLock, causing the initial known registration status to be ignored and potentially triggering unnecessary registration attempts. Set the OnceLock when args.registered is true, e.g. let mut lock = OnceLock::new(); if args.registered { let _ = lock.set(true); } and assign lock to the struct, or store the initial state separately.

Copilot · 2025-10-16T18:01:49Z

crates/op-rbuilder/src/flashtestations/builder_tx.rs

+                        signed_tx: register_tx,
+                        is_top_of_block: false,
+                    }),
+                    false,


After a successful simulated registration and construction of the real registration transaction, the returned boolean is false, preventing the caller from marking the TEE service as registered; this leads to an extra redundant registration attempt until a revert confirms TEEServiceAlreadyRegistered. Change the second tuple value to true to reflect successful registration.

Suggested change

false,

true,

Copilot · 2025-10-16T18:01:50Z

crates/op-rbuilder/src/flashtestations/builder_tx.rs

+        match self.register_tee_service_tx(ctx, &mut evm) {
+            Ok((_, registered)) => {
+                if registered {
+                    let _ = self.registered.set(registered);
+                }
+                Ok(())
+            }
+            Err(e) => Err(BuilderTransactionError::other(e)),
+        }


Successful new registrations (which currently return false from register_tee_service_tx) never set the OnceLock, so the builder repeats registration until a revert marks it as already registered; combined with the incorrect false return this wastes gas. After adjusting register_tee_service_tx to return true on success, set the flag unconditionally when registration succeeds or explicitly handle both success and already-registered cases.

Copilot · 2025-10-16T18:01:50Z

crates/op-rbuilder/src/flashtestations/builder_tx.rs

+        evm.modify_cfg(|cfg| {
+            cfg.disable_balance_check = true;
+        });
+        match self.register_tee_service_tx(ctx, &mut evm) {


Wrapping an existing BuilderTransactionError with BuilderTransactionError::other(e) erases its original variant, hindering downstream handling or pattern matching; return Err(e) directly to preserve semantic detail.

Copilot · 2025-10-16T18:01:50Z

crates/op-rbuilder/src/flashtestations/builder_tx.rs

+                }
+                Ok(())
+            }
+            Err(e) => Err(BuilderTransactionError::other(e)),


Wrapping an existing BuilderTransactionError with BuilderTransactionError::other(e) erases its original variant, hindering downstream handling or pattern matching; return Err(e) directly to preserve semantic detail.

Suggested change

Err(e) => Err(BuilderTransactionError::other(e)),

Err(e) => Err(e),

Copilot · 2025-10-16T18:01:50Z

crates/op-rbuilder/src/flashtestations/builder_tx.rs

+        let block_content_hash = Self::compute_block_content_hash(
+            transactions.clone(),
+            ctx.parent_hash(),


Cloning the entire transactions vector just to pass it into compute_block_content_hash is unnecessary and can incur allocation and copy costs; change compute_block_content_hash to accept a slice (&[OpTransactionSigned]) and pass transactions by reference to avoid cloning.

crates/op-rbuilder/src/builders/context.rs

Co-authored-by: Copilot <[email protected]>

Copilot

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-16T18:05:37Z

crates/op-rbuilder/src/flashtestations/builder_tx.rs

+        let block_content_hash = Self::compute_block_content_hash(
+            transactions.clone(),
+            ctx.parent_hash(),
+            ctx.block_number(),
+            ctx.timestamp(),
+        );


transactions.clone() is redundant because verify_block_proof_tx already owns the Vec. Remove the clone and pass transactions directly, or change compute_block_content_hash to accept &[OpTransactionSigned] to avoid unnecessary allocations.

Copilot · 2025-10-16T18:05:37Z

crates/op-rbuilder/src/flashtestations/builder_tx.rs

+            builder_txs.extend(self.verify_block_proof_tx(
+                info.executed_transactions.clone(),
+                ctx,
+                &mut evm,
+            )?);


Cloning info.executed_transactions here causes a full vector copy even when block proofs are enabled every block. If immutability is sufficient, pass a slice (&info.executed_transactions) and adjust verify_block_proof_tx to take &[OpTransactionSigned] to avoid repeated cloning.

avalonche requested review from SozinM and karim-agha as code owners October 1, 2025 22:39

avalonche changed the base branch from main to updated-registration October 1, 2025 22:39

avalonche force-pushed the add-flashtestation-builder-tx branch from 46380ae to 41c42bf Compare October 1, 2025 22:41

avalonche force-pushed the updated-registration branch from 79aff67 to 0b9b3a3 Compare October 2, 2025 05:44

avalonche force-pushed the add-flashtestation-builder-tx branch from 41c42bf to 01573b2 Compare October 2, 2025 05:45

SozinM reviewed Oct 2, 2025

View reviewed changes

avalonche force-pushed the updated-registration branch from 0b9b3a3 to 581ebac Compare October 2, 2025 17:47

avalonche force-pushed the add-flashtestation-builder-tx branch from 01573b2 to 32146ac Compare October 2, 2025 17:48

avalonche force-pushed the updated-registration branch from 581ebac to 8768d27 Compare October 3, 2025 17:47

Base automatically changed from updated-registration to main October 3, 2025 17:47

avalonche force-pushed the add-flashtestation-builder-tx branch from 32146ac to 2499332 Compare October 3, 2025 17:54

akundaz reviewed Oct 13, 2025

View reviewed changes

SozinM approved these changes Oct 16, 2025

View reviewed changes

Add flashtestation builder tx and registration in block

5787983

Copilot AI review requested due to automatic review settings October 16, 2025 18:00

avalonche force-pushed the add-flashtestation-builder-tx branch from 11f6b6a to 5787983 Compare October 16, 2025 18:00

avalonche requested a review from 0x416e746f6e as a code owner October 16, 2025 18:00

avalonche enabled auto-merge (squash) October 16, 2025 18:01

Copilot AI reviewed Oct 16, 2025

View reviewed changes

Update crates/op-rbuilder/src/builders/context.rs

e3c2a1f

Co-authored-by: Copilot <[email protected]>

Copilot AI review requested due to automatic review settings October 16, 2025 18:04

Copilot AI reviewed Oct 16, 2025

View reviewed changes

avalonche merged commit 5cd19de into main Oct 16, 2025
4 checks passed

avalonche deleted the add-flashtestation-builder-tx branch October 16, 2025 18:16

	Err(e) => Err(BuilderTransactionError::other(e)),
	Err(e) => Err(e),

Add flashtestation builder tx #282

Add flashtestation builder tx #282

Uh oh!

Conversation

avalonche commented Oct 1, 2025

📝 Summary

💡 Motivation and Context

✅ I have completed the following steps:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

akundaz Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

avalonche Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

akundaz Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

avalonche Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

avalonche Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

akundaz Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

avalonche Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!