add color flag for text log #871
Merged
+10
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharath-123
reviewed
Dec 1, 2025
| use Hoodi | ||
| -json | ||
| log in JSON format instead of text | ||
| -color |
Collaborator
There was a problem hiding this comment.
good to document that, this won't have any effect if -json is selected. A small sentence would be helpful.
Something like:
This option won't have any effect if -json is enabled.
metachris
approved these changes
Dec 1, 2025
bharath-123
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Introduces an optional
colorflag for text log fmtCloses #867
⛱ Motivation and Context
Previously we were enforcing color for text logs, this change makes it configurable, so users can choose depending on their preference.
📚 References
✅ I have run these commands
make lintmake test-racego mod tidy