Open
Conversation
Collaborator
|
Interesting, thanks for opening the PR! 🔥 |
pk910
reviewed
Jun 10, 2025
|
|
||
| func (r *VersionedSubmitBlockRequest) HashTreeRootWithManager(sszManager *SSZManager) (phase0.Root, error) { | ||
| if sszManager != nil && sszManager.IsInitialized() { | ||
| return sszManager.HashTreeRoot(r) |
There was a problem hiding this comment.
this will need the same switch/case logic as below.
you'll need to pass r.Capella / r.Deneb or r.Electra to sszManager.HashTreeRoot.
passing the whole versioned object will give you an invalid tree root (most likely throws an error too, as nil pointers are not allowed in ssz)
services/api/service.go
Outdated
| specConfig := make(map[string]interface{}) | ||
|
|
||
| // Add relevant fields from beacon spec | ||
| specConfig["SECONDS_PER_SLOT"] = strconv.FormatUint(beaconSpec.SecondsPerSlot, 10) |
There was a problem hiding this comment.
is this mapping really necessary?
Ideally you'll pass all spec values to dynssz, as it's not obvious if you mapped all the required spec values here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Implements dynamic SSZ encoding support to enable MEV-Boost relay compatibility with Ethereum minimal spec devnets, while maintaining full backward compatibility with mainnet/testnet operations.
Key Changes:
⛱ Motivation and Context
Faster iterative testing on devnets
📚 References
#738
✅ I have run these commands
make lintmake test-racego mod tidyCONTRIBUTING.md