refactor: updated data type of Value of FunctionCallDefinition to U256 #388
+35
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroXbrock
requested changes
Dec 4, 2025
Member
zeroXbrock
left a comment
zeroXbrock
left a comment
There was a problem hiding this comment.
Thanks for the PR, good first pass. I made a mistake in the original spec that requires some changes: FunctionCallDefinition.value actually does need to be Option<String> because the templater relies on strings to support placeholder injection. It's a tiny change on your end, but my mistake -- sorry bout that!
Once the changes I requested are addressed, the code will be ready to support values with units!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Issue: #387
Refactoring data type of Value of FunctionCallDefinition and FunctionCallDefinitionStrict to U256.
PR Checklist
cargo +nightly clippy --workspace --lib --examples --tests --benches --all-features --locked --fixcargo fmt --allCHANGELOG.mdin each affected crate