feat: monitor flashblocks arrival - #8
Open
0x416e746f6e wants to merge 6 commits into
Open
Conversation
to allow all flashblocks arrive before inspecting the block
0x416e746f6e
force-pushed
the
feat/monitor-flashblock-arrival
branch
from
April 10, 2026 14:25
0b12c0b to
aec78db
Compare
avalonche
reviewed
Jul 28, 2026
| for ctx.Err() == nil { | ||
| select { | ||
| case fb := <-fm.flashblocksPublic: | ||
| now := time.Now().UnixNano() |
Contributor
There was a problem hiding this comment.
shouldn't we use the fb.timestamp recv timestamp instead of channel dequeue timestamp?
avalonche
reviewed
Jul 28, 2026
| select { | ||
| case fb := <-fm.flashblocksPublic: | ||
| now := time.Now().UnixNano() | ||
| blockTime := 1000000000 * (fm.cfg.genesisTime + fm.cfg.secondsPerBlock*int64(fb.flashblock.Metadata.BlockNumber)) |
Contributor
There was a problem hiding this comment.
can use secondsPerBlock constant here
avalonche
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR adds monitoring of flashblocks arrival timings relative to block time.
this would allow us to see our flashblocks delivery performance.
UPD
also: