Add bootnode component for EL and CL nodes. #99
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing! Ferran is out of office at the moment and will be back next week. |
ferranbt
reviewed
Apr 21, 2025
internal/components.go
Outdated
| @@ -253,6 +254,7 @@ func (r *RethEL) Run(svc *service, ctx *ExContext) { | |||
| "--ipcpath", "{{.Dir}}/reth.ipc", | |||
| "--addr", "127.0.0.1", | |||
| "--port", `{{Port "rpc" 30303}}`, | |||
| "--bootnodes", "enode://"+defaultDiscoveryEnodeID+"@bootnode:30301", | |||
There was a problem hiding this comment.
You cannot hardcode any service name (bootnode in this case).
There was a problem hiding this comment.
hey @ferranbt! do i take it from commandline args? and only the service name? the port and enode ID will be like this right?
ferranbt
reviewed
Apr 21, 2025
| @@ -49,18 +53,33 @@ func (l *L1Recipe) Artifacts() *ArtifactsBuilder { | |||
| return builder | |||
| } | |||
|
|
|||
| func (m *Manifest) AddServiceWithDeps(name string, service Service, deps ...string) { | |||
There was a problem hiding this comment.
Dependencies are mostly defined at the components level, not at the recipe.
simon0x1800
force-pushed
the
add-bootnode
branch
2 times, most recently
from
265aeff to
c91c6c0
Compare
|
@ferranbt can you please check now if the changes look good? |
|
Hey, appreciate your work here. I am going to follow up the work myself here #147 because there are too many layers. This was not a correct "Good first issue". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I attempted to address #66 with this PR. @ferranbt please lmk if any changes need to be done