Mesh Adaptivity via DMPlexTransform by pbrubeck · Pull Request #5215 · firedrakeproject/firedrake

pbrubeck · 2026-07-03T17:19:50Z

Description

AI-assisted

Enables adaptivity on any simplicial mesh via DMPlex.adaptLabel()/DMPlex.transform()
Depends on https://gitlab.com/petsc/petsc/-/merge_requests/9412 (merged) which introduces 3D adaptivity

Enables prolong/restrict/inject to natively support adaptively-refined/redistributed hierarchies

Deprecate hierarchy-agnostic AdaptiveTransferManager in favour of TransferManager, now with adaptivity and parallel redistribution support.

RedistributedMeshTransfer was borrowed from @wence-'s unmerged branch main...wence/feature/redist-mg

pbrubeck · 2026-07-10T09:43:52Z

+    return dm
+
+
+def redistribute_dm(dm, parameters, grow_overlap=True):


add docstring

Co-authored-by: Pablo Brubeck <brubeck@protonmail.com>

pbrubeck · 2026-07-10T22:52:03Z

+    parent_label = dm.getLabel(parent_name)
+    adapt_label = dm.getLabel(adapt_name)
+    marks = cell_marker.dat.data_ro
+    for c in range(*dm.getHeightStratum(0)):


pbrubeck · 2026-07-10T22:52:16Z

+    nfine = new_mesh.cell_set.size
+    fine_to_coarse = np.full((nfine, 1), -1, dtype=IntType)
+    children = [[] for _ in range(ncoarse)]
+    for c in range(*new_dm.getHeightStratum(0)):


pbrubeck added 4 commits July 3, 2026 15:21

Native/redistributed transfer for AdaptiveMeshHierarcy

b4153b7

Merge branch 'pbrubeck/snes-adapt' into pbrubeck/mg-redist

c999b13

Works in serial

d588985

WIP: RedistMesh

46e2514

pbrubeck changed the title ~~Native support for redistributed AdaptiveMeshHierarchy~~ TransferManager: support a redistributed AdaptiveMeshHierarchy Jul 3, 2026

pbrubeck force-pushed the pbrubeck/mg-redist branch 2 times, most recently from 404f925 to 381f544 Compare July 3, 2026 19:51

Deprecate AdaptiveTransferManager

885a7eb

pbrubeck force-pushed the pbrubeck/mg-redist branch from 381f544 to 885a7eb Compare July 3, 2026 19:56

WIP struggled a lot with injection

c8b3473

pbrubeck commented Jul 3, 2026

View reviewed changes

Comment thread firedrake/mg/interface.py Outdated

pbrubeck added 9 commits July 3, 2026 23:35

remove anti-patterns

2e0ef75

workaround

a60293f

fix parallel

e24125e

add failing redistribution test

6c37126

cleanup

c9fba85

Redistributed MeshHierarchy

f978cf9

refactoring, and some FIXMEs

4e4bbeb

Fix RedistMesh + AdaptiveMeshHierarchy

a810d2f

refactoring

3df8ca5

pbrubeck commented Jul 5, 2026

View reviewed changes

Comment thread firedrake/mg/adaptive_hierarchy.py Outdated

pbrubeck commented Jul 5, 2026

View reviewed changes

Comment thread firedrake/netgen.py Outdated

pbrubeck commented Jul 5, 2026

View reviewed changes

Comment thread firedrake/netgen.py Outdated

pbrubeck commented Jul 5, 2026

View reviewed changes

Comment thread firedrake/netgen.py Outdated

pbrubeck commented Jul 5, 2026

View reviewed changes

Comment thread firedrake/netgen.py Outdated

pbrubeck commented Jul 5, 2026

View reviewed changes

Comment thread firedrake/mg/utils.py Outdated

pbrubeck commented Jul 5, 2026

View reviewed changes

Comment thread firedrake/mg/utils.py Outdated

pbrubeck commented Jul 5, 2026

View reviewed changes

Comment thread firedrake/mg/utils.py Outdated

pbrubeck commented Jul 5, 2026

View reviewed changes

Comment thread firedrake/mg/utils.py Outdated

pbrubeck commented Jul 5, 2026

View reviewed changes

Comment thread firedrake/mg/mesh.py Outdated

pbrubeck commented Jul 10, 2026

View reviewed changes

Comment thread firedrake/mg/mesh.py Outdated

pbrubeck commented Jul 10, 2026

View reviewed changes

Comment thread firedrake/mg/mesh.py Outdated

pbrubeck commented Jul 10, 2026

View reviewed changes

Comment thread firedrake/mg/mesh.py

pbrubeck commented Jul 10, 2026

View reviewed changes

Comment thread firedrake/redist.py Outdated

pbrubeck commented Jul 10, 2026

View reviewed changes

Comment thread firedrake/adapt.py Outdated

pbrubeck added 3 commits July 10, 2026 10:46

Apply suggestions from code review

098ca74

Co-authored-by: Pablo Brubeck <brubeck@protonmail.com>

Apply suggestion from @pbrubeck

3e21650

Apply suggestion from @pbrubeck

5a0306a

pbrubeck commented Jul 10, 2026

View reviewed changes

Comment thread firedrake/mg/mesh.py Outdated

Apply suggestion from @pbrubeck

f3d5e67

pbrubeck commented Jul 10, 2026

View reviewed changes

Comment thread firedrake/mg/mesh.py Outdated

pbrubeck added 2 commits July 10, 2026 10:52

Apply suggestions from code review

27a5260

Co-authored-by: Pablo Brubeck <brubeck@protonmail.com>

fixes

8339a52

pbrubeck commented Jul 10, 2026

View reviewed changes

Comment thread firedrake/mg/mesh.py Outdated

pbrubeck commented Jul 10, 2026

View reviewed changes

Comment thread firedrake/mg/mesh.py Outdated

pbrubeck commented Jul 10, 2026

View reviewed changes

Comment thread firedrake/mg/mesh.py Outdated

Apply suggestions from code review

b25d720

Co-authored-by: Pablo Brubeck <brubeck@protonmail.com>

pbrubeck commented Jul 10, 2026

View reviewed changes

Comment thread firedrake/mg/mesh.py Outdated

Apply suggestion from @pbrubeck

0c87d21

pbrubeck commented Jul 10, 2026

View reviewed changes

Comment thread firedrake/mg/mesh.py Outdated

Apply suggestions from code review

9be2fbe

Co-authored-by: Pablo Brubeck <brubeck@protonmail.com>

pbrubeck commented Jul 10, 2026

View reviewed changes

Comment thread firedrake/mg/mesh.py Outdated

pbrubeck added 3 commits July 10, 2026 11:21

Apply suggestion from @pbrubeck

60aa61b

fix inject

7b4f5d8

Deterministic tests

5e9b4cb

pbrubeck changed the title ~~TransferManager: support a redistributed AdaptiveMeshHierarchy~~ Mesh Adaptivity via DMPlexTransform Jul 10, 2026

pbrubeck mentioned this pull request Jul 10, 2026

Destroy object the PETSc garbage collector would have issue with #5235

Open

pbrubeck commented Jul 10, 2026

View reviewed changes

		return dm


		def redistribute_dm(dm, parameters, grow_overlap=True):

Uh oh!

Conversation

pbrubeck commented Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pbrubeck Jul 10, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pbrubeck Jul 10, 2026

Choose a reason for hiding this comment

Uh oh!

pbrubeck Jul 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

pbrubeck commented Jul 3, 2026 •

edited

Loading