Skip to content

fix(go/ai): move input.default into input map for DevUI compatibility #4540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
yesudeep wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix(go/ai): move input.default into input map for DevUI compatibility #4540

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ce7117
fix(go/ai): move input.default into input map for DevUI compatibility
yesudeep Feb 9, 2026
2af177f
fix(go/ai): chain type assertions to prevent panics from malformed me…
yesudeep Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions go/ai/prompt.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,15 +105,14 @@ func DefinePrompt(r api.Registry, name string, opts ...PromptOption) Prompt {
baseName, variant, _ := strings.Cut(name, ".")

promptMetadata := map[string]any{
"name": baseName,
"description": p.Description,
"model": modelName,
"config": p.Config,
"input": map[string]any{"schema": p.InputSchema},
"output": map[string]any{"schema": p.OutputSchema},
"defaultInput": p.DefaultInput,
"tools": tools,
"maxTurns": p.MaxTurns,
"name": baseName,
"description": p.Description,
"model": modelName,
"config": p.Config,
"input": map[string]any{"schema": p.InputSchema, "default": p.DefaultInput},
"output": map[string]any{"schema": p.OutputSchema},
"tools": tools,
"maxTurns": p.MaxTurns,
}
if variant != "" {
promptMetadata["variant"] = variant
Expand Down Expand Up @@ -304,7 +303,9 @@ func (p *prompt) Render(ctx context.Context, input any) (*GenerateActionOptions,

// TODO: This is hacky; we should have a helper that fetches the metadata.
if input == nil {
input = p.Desc().Metadata["prompt"].(map[string]any)["defaultInput"]
if inputMeta, ok := p.Desc().Metadata["prompt"].(map[string]any)["input"].(map[string]any); ok {
input = inputMeta["default"]
}
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change improves safety by using the value, ok pattern for one of the type assertions. However, it can still panic if p.Desc().Metadata["prompt"] is not of type map[string]any. To make this fully safe against panics from malformed metadata, you can chain the type assertions as suggested.

		if promptMeta, ok := p.Desc().Metadata["prompt"].(map[string]any); ok {
			if inputMeta, ok := promptMeta["input"].(map[string]any); ok {
				input = inputMeta["default"]
			}
		}

}

return p.Run(ctx, input, nil)
Expand Down
Loading