Skip to content

Conversation

@fabiovincenzi
Copy link
Contributor

Description:
This PR introduces end-to-end support for annotated tag pushes

  • Split the push pipeline into separate branchPushChain and tagPushChain.
  • Update getChain() to select the correct chain based on action.type and presence of action.tag.
  • Render a dedicated “Tag Details” table when viewing a tag push instead of the commit diff.

Fixes #986

@netlify
Copy link

netlify bot commented Jun 11, 2025

Deploy Preview for endearing-brigadeiros-63f9d0 ready!

Name Link
🔨 Latest commit 92318e9
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/688a2fc485a3a90008d10f8f
😎 Deploy Preview https://deploy-preview-1051--endearing-brigadeiros-63f9d0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Jun 11, 2025

Codecov Report

Attention: Patch coverage is 82.43243% with 26 lines in your changes missing coverage. Please review.

Project coverage is 81.52%. Comparing base (0e60143) to head (f3af7e7).

Files with missing lines Patch % Lines
src/proxy/processors/push-action/parsePush.ts 76.38% 3 Missing and 14 partials ⚠️
src/ui/utils/pushUtils.ts 86.44% 2 Missing and 6 partials ⚠️
.../proxy/processors/push-action/checkAuthorEmails.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1051      +/-   ##
==========================================
+ Coverage   77.40%   81.52%   +4.11%     
==========================================
  Files          56       57       +1     
  Lines        2288     2376      +88     
  Branches      258      292      +34     
==========================================
+ Hits         1771     1937     +166     
+ Misses        487      389      -98     
- Partials       30       50      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fabiovincenzi fabiovincenzi marked this pull request as ready for review July 24, 2025 12:08
Copy link
Contributor

@jescalada jescalada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leaving some comments after looking through the code, will update after testing the flow.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a heads up: looks like this'll have a lot of conflicts with the upcoming changes... Though, we probably want to merge this as a v2 feature anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants