feat: SSH UI #1033
Open
feat: SSH UI #1033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
dcoric
suggested changes
Jun 4, 2025
There was a problem hiding this comment.
Review Note:
The implementation looks good overall, but we need to address the SSH port handling in clone URLs.
Requested Changes:
- Currently when a non-standard SSH port is configured, the clone URL format needs to be adjusted to:
git clone ssh://git@${host}:${SSHport}/${path}
dcoric
reviewed
Jun 6, 2025
There was a problem hiding this comment.
Looks good now! This is a bit larger PR since it's built on top of the SSH functionality PR. I've reviewed the UI portion (since the SSH changes are in the other PR).
One suggestion: it might make more sense to target this PR against the original SSH branch rather than main. That way, both features could be reviewed and merged together as a complete feature set. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an SSH-key management UI. Based on #987
To ease review, a separate PR has been opened against the SSH integration branch to highlight only the UI-related changes: G-Research#52
Frontend
Backend – Two endpoints make it work:
GET /:username/ssh-keys→ returns all fingerprints for the user.DELETE /:username/ssh-keys/fingerprint→ accepts { fingerprint } in the body and removes the matching key.