-
Notifications
You must be signed in to change notification settings - Fork 134
test: improve proxy route test coverage #1025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jescalada
wants to merge
11
commits into
finos:main
Choose a base branch
from
jescalada:improve-plugin-test-coverage
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1025 +/- ##
==========================================
+ Coverage 48.51% 53.46% +4.94%
==========================================
Files 51 52 +1
Lines 2092 2108 +16
Branches 241 243 +2
==========================================
+ Hits 1015 1127 +112
+ Misses 1040 942 -98
- Partials 37 39 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves test coverage for
/src/proxy/routes
. Overall project coverage should increase by ~5%.Originally, I wanted to improve coverage for
/plugin.ts
, however I've been having problems with the tests not executing due to an ESM interop problem when using theplugin-loader
library.I added a
skip
on all the problematic tests inplugin.test.js
, and kept the ones that do work.I tried a few workarounds (such as executing with regular
mocha
+tsx
loader, running withvitest
) without any luck. The only working solution I found so far is to upgrade to Node 22.