Skip to content

test: improve proxy route test coverage #1025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

jescalada
Copy link
Contributor

@jescalada jescalada commented May 23, 2025

This PR improves test coverage for /src/proxy/routes. Overall project coverage should increase by ~5%.

Originally, I wanted to improve coverage for /plugin.ts, however I've been having problems with the tests not executing due to an ESM interop problem when using the plugin-loader library.

I added a skip on all the problematic tests in plugin.test.js, and kept the ones that do work.

I tried a few workarounds (such as executing with regular mocha + tsx loader, running with vitest) without any luck. The only working solution I found so far is to upgrade to Node 22.

Copy link

netlify bot commented May 23, 2025

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 4cc15cf
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/683162d386efca000862c49b

Copy link

codecov bot commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.46%. Comparing base (fc6f166) to head (4cc15cf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1025      +/-   ##
==========================================
+ Coverage   48.51%   53.46%   +4.94%     
==========================================
  Files          51       52       +1     
  Lines        2092     2108      +16     
  Branches      241      243       +2     
==========================================
+ Hits         1015     1127     +112     
+ Misses       1040      942      -98     
- Partials       37       39       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jescalada jescalada changed the title test: improve plugin test coverage test: improve proxy route test coverage May 24, 2025
@jescalada jescalada marked this pull request as ready for review May 24, 2025 06:33
@JamieSlome JamieSlome requested a review from 06kellyjac June 17, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Testing]: Improve test coverage for OIDC and authentication changes
1 participant