-
Notifications
You must be signed in to change notification settings - Fork 12
Mobile 273/firebase distribution #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/3.9.0
Are you sure you want to change the base?
Mobile 273/firebase distribution #75
Conversation
| run: | | ||
| RESPONSE=$(curl -s \ | ||
| -H "Authorization: Bearer $GITHUB_TOKEN" \ | ||
| https://api.github.com/repos/fingerprintjs/fingerprintjs-pro-android-private/releases/latest) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't look right for me. As we're targeting main, we should fetch SDK from reposilite. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexzfp As mentioned above in description, this is still not fully tested. Raised to validate it from Actions. I will revalidate it again as requested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@manjunathnijaguna-fp could you convert PR to draft mode then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was afraid that the Draft mode won't trigger the actions. so i have created as PR and mentioned in Descrption.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it will
Purpose
Upload APK to firebase and add more github actions
Change summary
<Validation in progress, PR is not ready completly yet>