Skip to content

Fix: Column view trace not updating on theme change #18056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
R0h1tAnand wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −0
Open

Fix: Column view trace not updating on theme change #18056

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/Files.App/Views/Layouts/ColumnLayoutPage.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ protected override void OnNavigatedTo(NavigationEventArgs eventArgs)
currentIconSize = LayoutSizeKindHelper.GetIconSize(FolderLayoutModes.ColumnView);

UserSettingsService.LayoutSettingsService.PropertyChanged += LayoutSettingsService_PropertyChanged;
this.ActualThemeChanged += ColumnLayoutPage_ActualThemeChanged;

SetItemContainerStyle();
}
Expand All @@ -197,6 +198,7 @@ protected override void OnNavigatingFrom(NavigatingCancelEventArgs e)
{
base.OnNavigatingFrom(e);
UserSettingsService.LayoutSettingsService.PropertyChanged -= LayoutSettingsService_PropertyChanged;
this.ActualThemeChanged -= ColumnLayoutPage_ActualThemeChanged;
ParentShellPageInstance.ShellViewModel.ItemLoadStatusChanged -= OnItemLoadStatusChanged;
}

Expand Down Expand Up @@ -226,6 +228,15 @@ private void LayoutSettingsService_PropertyChanged(object? sender, PropertyChang
}
}

private void ColumnLayoutPage_ActualThemeChanged(FrameworkElement sender, object args)
{
// Reapply the folder background when theme changes
if (openedFolderPresenter is not null)
{
SetFolderBackground(openedFolderPresenter, this.Resources["ListViewItemBackgroundSelected"] as SolidColorBrush);
}
}

private async Task ReloadItemIconsAsync()
{
if (ParentShellPageInstance is null)
Expand Down
Loading