Feature: Add disk based thumbnail caching system#17991
Open
workbysaran wants to merge 40 commits intofiles-community:mainfrom
Open
Feature: Add disk based thumbnail caching system#17991workbysaran wants to merge 40 commits intofiles-community:mainfrom
workbysaran wants to merge 40 commits intofiles-community:mainfrom
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
…new row for Clear Cache button
0x5bfa
reviewed
Jan 7, 2026
Member
There was a problem hiding this comment.
Changes are looking good as far as I can tell as of now. This code will still remain for the time being but we should use the built-in windows API to get thumbnail cache in the future. (Looks like IThumbnailProvider in the new Storage Abstraction API WindowsStorableHelpers.GetThumbnail already calls, nice)
Signed-off-by: Yair <39923744+yaira2@users.noreply.github.com>
yair100
reviewed
Jan 13, 2026
yair100
force-pushed
the
sg/feature-thumbnail-cache
branch
from
ea17047 to
e0fb9ae
Compare
yair100
reviewed
Jan 14, 2026
yair100
reviewed
Jan 14, 2026
8 tasks
yair100
force-pushed
the
sg/feature-thumbnail-cache
branch
from
1962f3a to
14e6e26
Compare
Comment on lines
89
to
98
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Signed-off-by: Saravanan G <workbysaran@gmail.com>
Comment on lines
38
to
39
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| using var connection = CreateConnection(); | ||
| using var cmd = connection.CreateCommand(); | ||
| cmd.CommandText = """ | ||
| INSERT OR IGNORE INTO thumbnails (path, size, icon_type, file_modified, file_size, cloud_status, data, last_accessed) |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
|
Will we need a button in settings to rebuild the thumbnail cache? |
…ysaran/Files into sg/feature-thumbnail-cache
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Related to #4180
Addresses performance issues caused by repeated Shell API thumbnail generation by introducing a disk based LRU cache and a centralized ThumbnailService.
Steps used to test these changes
TODO