Skip to content

Code Quality: Improved Omnibar UX 2 #17157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Jun 12, 2025

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented May 26, 2025

Resolved / Related Issues

Supposedly, this is going to be the final PR before Omnibar Search mode.

Steps used to test these changes

  1. Open Files app
  2. Test the focus managements
  3. Test the tooltip comprehensiveness

yaira2
yaira2 previously approved these changes May 26, 2025
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 force-pushed the 5bfa/CQ-OmnibarUX2 branch from 300d36e to d57ebac Compare June 10, 2025 21:54
@yaira2 yaira2 force-pushed the 5bfa/CQ-OmnibarUX2 branch from e6e6b8f to 887021b Compare June 10, 2025 21:57
@yaira2 yaira2 force-pushed the 5bfa/CQ-OmnibarUX2 branch from 7678c24 to adb6e79 Compare June 10, 2025 22:33
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jun 12, 2025
@yaira2 yaira2 marked this pull request as ready for review June 12, 2025 14:18
@yaira2 yaira2 merged commit 083ef0e into files-community:main Jun 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants