Fix sshfs mounts from interrupting the disk monitor #185
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- df can exit with an error while still printing the filesystem info we need.
- The df command can return a non-zero exit status but still contain enough info for us to parse local disk sizes.
There was a problem hiding this comment.
Pull Request Overview
A fix to prevent SSHFS mounts from disrupting the disk monitor, plus minor updates for test tracking and changelog.
- Process filesystem output even if the subprocess exits with a non-zero status.
- Add a TODO reminding to add unit tests for temperature sensor configurations.
- Update
RELEASES.mdto record the SSHFS mount fix.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/helpers.ts | Changed exit-status check to process stdout regardless of success, ensuring SSHFS mounts are included. |
| src/extension.ts | Inserted a TODO to add unit tests for known temperature sensors. |
| RELEASES.md | Added a changelog entry for the SSHFS-related disk monitor fix. |
Comments suppressed due to low confidence (1)
src/extension.ts:95
- This TODO highlights missing unit tests for sensor parsing; please add tests covering each supported temperature sensor to ensure correctness.
// TODO: Add unit tests for each known temperature sensor configuration
Comment on lines
140
to
+143
| Gio.SubprocessFlags.STDOUT_PIPE | ||
| ); | ||
| proc.communicate_utf8_async(null, null).then(([stdout]) => { | ||
| if (proc.get_successful()) { | ||
| // Try to process the output even if the exit status != 0 |
There was a problem hiding this comment.
Consider also capturing or logging stderr and the exit code when stdout is present but the subprocess failed, to aid debugging of unexpected failures.
|
|
||
| ## TopHat vNext - Unreleased | ||
|
|
||
| - Fixed disk monitor problem with sshfs mounts |
There was a problem hiding this comment.
It may be helpful to reference the related PR or issue number in this changelog entry for better traceability.
Suggested change
| - Fixed disk monitor problem with sshfs mounts | |
| - Fixed disk monitor problem with sshfs mounts (#4567) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.