Implementation of the first layer of the SSE Implementation for the Generator to consume #7535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enerator to consume
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
amckinney
reviewed
Jun 16, 2025
amckinney
reviewed
Jun 16, 2025
amckinney
reviewed
Jun 16, 2025
added 2 commits
June 16, 2025 16:54
| streaming.visit(new GetStreamingResponseTerminator()).orElse("\n"); | ||
| String prefix = ":data "; |
There was a problem hiding this comment.
The prefix value ":data " doesn't match the DEFAULT_VALUE_PREFIX of "data: " defined in Stream.java. This inconsistency will cause SSE parsing to fail since the stream parser will be looking for lines starting with "data: " but the actual data will be prefixed with ":data ". Please update this value to "data: " to ensure consistent behavior with the default implementation.
Suggested change
| String prefix = ":data "; | |
| String prefix = "data: "; |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fern SDKs support a variety of powerful features like auto-pagination, retries, and streaming. Java supports newline-delimited JSON streaming, but we haven't built out server-side event (SSE) streaming yet. This PR is the first step in enabling the generator to accept SSE on Java
Changes Made
Testing