Skip to content

Remove switch arg in DropHighPSIFeatures #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sancholp
Copy link

Closes #858.

PSI is a symmetric metric and as such the switch arg doesn't add functionality.

Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (ead2457) to head (b163c36).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #859      +/-   ##
==========================================
- Coverage   98.04%   98.03%   -0.01%     
==========================================
  Files         111      111              
  Lines        4643     4638       -5     
  Branches      739      737       -2     
==========================================
- Hits         4552     4547       -5     
  Misses         56       56              
  Partials       35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sancholp
Copy link
Author

@solegalli Whenever you find time please have a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The switch argument in DropHighPSIFeatures should be removed
1 participant