Skip to content

Pt2.6 compatibility #5611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vviitani-amd
Copy link

Before submitting

  • [x ] Was this discussed/approved via a Github issue? (no need for typos, doc improvements)

  • [ x] Did you read the contributor guideline?

  • Did you make sure to update the docs? (no need)

  • Did you write any new necessary tests? (no need)

What does this PR do?

Fixes #5610.

The default value for the weights_only argument in torch.load() changed from False to True between PyTorch versions 2.5 and 2.6. By explicitly including weights_only=False in the torch.load calls, the code is kept working in the same way as previously also in PyTorch >= 2.6.

@facebook-github-bot
Copy link
Contributor

Hi @vviitani-amd!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External torch.hub.load('pytorch/fairseq:main', 'xlmr.large') causes WeightsUnpickler error for PyTorch version 2.6
2 participants