Skip to content

Upgrade GitHub Actions for Node 24 compatibility #5112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
salmanmkc wants to merge 1 commit into from
+30 −30
Closed

Upgrade GitHub Actions for Node 24 compatibility #5112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 21 additions & 21 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ jobs:
run:
working-directory: ./vscode-extension
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- uses: actions/checkout@v6
- uses: actions/setup-node@v6
with:
node-version: 20.x
cache: "yarn"
Expand All @@ -36,8 +36,8 @@ jobs:
matrix:
node-version: [18.x, 20.x]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- uses: actions/checkout@v6
- uses: actions/setup-node@v6
with:
node-version: ${{ matrix.node-version }}
cache: "yarn"
Expand All @@ -50,8 +50,8 @@ jobs:
name: JS Lint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- uses: actions/checkout@v6
- uses: actions/setup-node@v6
with:
node-version: 20.x
cache: "yarn"
Expand All @@ -68,8 +68,8 @@ jobs:
name: Flow Typecheck
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- uses: actions/checkout@v6
- uses: actions/setup-node@v6
with:
node-version: 20.x
cache: "yarn"
Expand All @@ -92,7 +92,7 @@ jobs:
os: windows-latest
runs-on: ${{ matrix.target.os }}
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
- uses: actions-rs/toolchain@v1
with:
# Should stay in sync with fbcode/buck2/rust-toolchain
Expand All @@ -118,7 +118,7 @@ jobs:
# os: windows-latest
runs-on: ${{ matrix.target.os }}
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
- uses: actions-rs/toolchain@v1
with:
# Should stay in sync with fbcode/buck2/rust-toolchain
Expand All @@ -139,7 +139,7 @@ jobs:
name: Rust Lint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
- uses: actions-rs/toolchain@v1
with:
# Should stay in sync with tools/third-party/rustfmt/.rustfmt-version
Expand Down Expand Up @@ -181,7 +181,7 @@ jobs:
artifact-name: relay-bin-win-x64
runs-on: ${{ matrix.target.os }}
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
- uses: actions-rs/toolchain@v1
with:
# Should stay in sync with fbcode/buck2/rust-toolchain
Expand All @@ -190,7 +190,7 @@ jobs:
toolchain: nightly-2025-08-01
override: true
target: ${{ matrix.target.target }}
- uses: actions/setup-node@v4
- uses: actions/setup-node@v6
if: github.event_name == 'push' && github.repository == 'facebook/relay' && github.ref == 'refs/heads/main'
with:
node-version: 20.x
Expand Down Expand Up @@ -219,7 +219,7 @@ jobs:
- name: Build project
working-directory: compiler
run: ${{ matrix.target.cross && 'cross' || 'cargo' }} build --release --target ${{ matrix.target.target }} ${{ matrix.target.features && '--features' }} ${{ matrix.target.features }}
- uses: actions/upload-artifact@v4
- uses: actions/upload-artifact@v6
with:
name: ${{ matrix.target.artifact-name }}
path: compiler/target/${{ matrix.target.target }}/release/${{ matrix.target.build-name }}
Expand All @@ -230,36 +230,36 @@ jobs:
if: github.event_name == 'push' && github.repository == 'facebook/relay'
needs: [js-tests, js-lint, typecheck, build-tests, build-compiler]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- uses: actions/checkout@v6
- uses: actions/setup-node@v6
with:
node-version: 18.x
registry-url: https://registry.npmjs.org/
cache: "yarn"
- name: Install dependencies
run: yarn install --frozen-lockfile --ignore-scripts
- name: Download artifact relay-bin-linux-x64
uses: actions/download-artifact@v4
uses: actions/download-artifact@v7
with:
name: relay-bin-linux-x64
path: artifacts/linux-x64
- name: Download artifact relay-bin-linux-arm64
uses: actions/download-artifact@v4
uses: actions/download-artifact@v7
with:
name: relay-bin-linux-arm64
path: artifacts/linux-arm64
- name: Download artifact relay-bin-macos-x64
uses: actions/download-artifact@v4
uses: actions/download-artifact@v7
with:
name: relay-bin-macos-x64
path: artifacts/macos-x64
- name: Download artifact relay-bin-macos-arm64
uses: actions/download-artifact@v4
uses: actions/download-artifact@v7
with:
name: relay-bin-macos-arm64
path: artifacts/macos-arm64
- name: Download artifact relay-bin-win-x64
uses: actions/download-artifact@v4
uses: actions/download-artifact@v7
with:
name: relay-bin-win-x64
path: artifacts/win-x64
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/docusaurus.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
name: Build Compiler Explorer
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
- uses: actions-rs/toolchain@v1
with:
# Should stay in sync with fbcode/buck2/rust-toolchain
Expand All @@ -31,7 +31,7 @@ jobs:
- name: "Build Compiler Playground Wasm NPM package"
run: wasm-pack build --target web
working-directory: ./compiler/crates/relay-compiler-playground
- uses: actions/upload-artifact@v4
- uses: actions/upload-artifact@v6
with:
name: compiler-playground-package
path: compiler/crates/relay-compiler-playground/pkg/
Expand All @@ -41,28 +41,28 @@ jobs:
needs: [build-compiler-explorer]
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v6
with:
persist-credentials: false

- name: Setup Node
uses: actions/setup-node@v4
uses: actions/setup-node@v6
with:
node-version: "20"
cache: "yarn"
cache-dependency-path: website/yarn.lock

- name: Set up Docusaurus Build Cache
id: cache-docusaurus
uses: actions/cache@v4
uses: actions/cache@v5
with:
path: |
website/node_modules/.cache
website/.docusaurus
key: "docusaurus-build-${{ hashFiles('website/yarn.lock') }}"

- name: Download Compiler Explorer
uses: actions/download-artifact@v4
uses: actions/download-artifact@v7
with:
name: compiler-playground-package
path: tmp/compiler-playground-package
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-cargo-lock.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
name: Update Cargo.lock file
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v6
- uses: actions-rs/toolchain@v1
with:
# Should stay in sync with fbcode/buck2/rust-toolchain
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/vscode.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ jobs:
run:
working-directory: ./vscode-extension
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- uses: actions/checkout@v6
- uses: actions/setup-node@v6
with:
node-version: 20.x
cache: 'yarn'
Expand Down
Loading