Skip to content

Conversation

@dharun-web
Copy link

Changes Made

  • Updated mlx dependency in setup.py from ==0.22.0 to >=0.22.1.
  • Adjusted mlx-lm to >=0.21.1 for consistency.

Why This Is Needed

  • mlx==0.22.0 does not exist in PyPI, causing installation failures on Apple Silicon (macOS).
  • This change ensures compatibility with available versions while maintaining functionality.

Testing

  1. Local Verification:
    pip install -e .  # Successfully installed mlx>=0.22.1

@AbhiByte
Copy link

AbhiByte commented Jun 28, 2025

lgtm!

@manueltarouca
Copy link

Nice

@pierow2k
Copy link

Wouldn't it be safer to pin to ==0.22.1 (which is available on PyPI) rather than opening it up with >=0.22.1? A looser constraint could let through future, untested releases that might break the build.

Have we confirmed that all versions newer than 0.22.1 are compatible? (Up through 0.26.1 in the case of mlx and through 0.25.2 in the case of mlx-lm)

Copy link

@anirudhp06 anirudhp06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When u mention

Updated mlx dependency in setup.py from ==0.22.0 to >=0.22.1

But when checked in files of your commit, you have only changed ==0.22.0 to >=0.22.0 which is completely different from what the commit message.

Is this something you missed while checking or is it intentional?

@mymstudios
Copy link

image

@AlexCheema AlexCheema force-pushed the main branch 2 times, most recently from a39f85b to 56f783b Compare October 21, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants