fix: prevent form submission during IME composition #818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue with Enter key handling during Chinese (and other IME-based) text input
AlexCheema
force-pushed
the
main
branch
2 times, most recently
from
a39f85b to
56f783b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue with Enter key handling during Chinese (and other IME-based) text input
Add detection for IME composition state using event.isComposing flag
Add fallback check for keyCode 229 which indicates IME processing
Prevent message submission when Enter is pressed during active IME composition
Allow normal Enter behavior for confirming IME selections
Maintains existing Shift+Enter functionality for line breaks
Before:
2025-04-14.9.28.49.mov
After:
2025-04-14.9.29.48.mov