Don't assume all network interfaces are /24 in size #810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than replacing the final octet of each local address with .255, look in "ifconfig" (mac), "ip addr" (linux), or "ipconfig /all" (windows) for the correct netmask and create the actual broadcast address. This fixes issues where a device has multiple nearby /30 interfaces where the first three octets were identical, causing the wrong broadcast address to get used. e.g. if the host has 1.0.0.1/30 and 1.0.0.5/30, both interfaces were attempting to broadcast to 1.0.0.255 which is incorrect. This patch makes it correctly send broadcasts to 1.0.0.4 and 1.0.0.8. This is tested and in use in Mac and Linux, but only a simple test on Windows was done since we aren't using that here.
AlexCheema
force-pushed
the
main
branch
2 times, most recently
from
a39f85b to
56f783b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than replacing the final octet of each local address with .255, look in "ifconfig" (mac), "ip addr" (linux), or "ipconfig /all" (windows) for the correct netmask and create the actual broadcast address.
This fixes issues where a device has multiple nearby /30 interfaces where the first three octets were identical, causing the wrong broadcast address to get used.
e.g. if the host has 1.0.0.1/30 and 1.0.0.5/30, both interfaces were attempting to broadcast to 1.0.0.255 which is incorrect. This patch makes it correctly send broadcasts to 1.0.0.4 and 1.0.0.8.
This is tested and in use in Mac and Linux, but only a simple test on Windows was done since we aren't using that here.