Templates: add NEcharge charger (OCPP 1.6J)#31631
Draft
Wupsman wants to merge 2 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've found 2 security issues
Security issues:
- Insecure WebSocket Detected. WebSocket Secure (wss) should be used for all WebSocket connections. (link)
- Insecure WebSocket Detected. WebSocket Secure (wss) should be used for all WebSocket connections. (link)
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="templates/definition/charger/necharge.yaml" line_range="11" />
<code_context>
NEcharge auf `ws://<evcc-adresse>:8887/` setzen (SoftAP-Konfigmodus bzw. App).
</code_context>
<issue_to_address>
**security (javascript.lang.security.detect-insecure-websocket):** Insecure WebSocket Detected. WebSocket Secure (wss) should be used for all WebSocket connections.
*Source: opengrep*
</issue_to_address>
### Comment 2
<location path="templates/definition/charger/necharge.yaml" line_range="16" />
<code_context>
`ws://<evcc-host>:8887/` (via the SoftAP setup mode or the app).
</code_context>
<issue_to_address>
**security (javascript.lang.security.detect-insecure-websocket):** Insecure WebSocket Detected. WebSocket Secure (wss) should be used for all WebSocket connections.
*Source: opengrep*
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a charger template for the NEcharge Pro. It speaks OCPP 1.6J; the template wraps the generic ocpp charger with branding and setup guidance.
It documents two NEcharge-specific details that are useful for users:
wss.Tested against a NEcharge Pro (OCPP station id NECH-BE1600057) running against evcc.