Skip to content

Conversation

@Himanshu-370
Copy link
Contributor

  • Create scripts/fix/bom.sh to generate bill-of-materials.json
  • Use load_workspace_relative_modules_for_bom for proper module list
  • Protect go.sum and go.mod with temporary backups during generation
  • Run license-bill-of-materials with GOOS=linux for consistent output
  • Add ETCD_ROOT_DIR support for dynamic path resolution
  • Update Makefile fix-bom target to use the new script

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Himanshu-370
Once this PR has been reviewed and has the lgtm label, please assign siyuanfoundation for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @Himanshu-370. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivanvc
Copy link
Member

ivanvc commented Jan 15, 2026

Thanks for the pull request, @Himanshu-370. Two comments:

  1. Please remove the script scripts/updatebom.sh to avoid confusion
  2. There's an intentional first execution to avoid issues in a clean repository, which you didn't port. Refer to:
    # Intentionally run the command once first, so it fetches dependencies. The exit code on the first
    # run in a just cloned repository is always dirty.
    GOOS=linux run_go_tool github.com/appscodelabs/license-bill-of-materials \
    --override-file ./bill-of-materials.override.json "${_bom_modules[@]}" &>/dev/null

- Create scripts/fix/bom.sh to generate bill-of-materials.json
- Add intentional first execution to fetch dependencies (avoids dirty state in clean repos)
- Use load_workspace_relative_modules_for_bom for proper module list
- Protect go.sum and go.mod with temporary backups during generation
- Run license-bill-of-materials with GOOS=linux for consistent output
- Add ETCD_ROOT_DIR support for dynamic path resolution
- Update Makefile fix-bom target to use the new script
- Remove scripts/updatebom.sh (functionality now in scripts/fix/bom.sh)

Signed-off-by: Himanshu Singh <[email protected]>
@Himanshu-370 Himanshu-370 force-pushed the himanshu/fix-bom.sh_file branch from 6e3d7b7 to 046d609 Compare January 16, 2026 00:21
@Himanshu-370
Copy link
Contributor Author

Removed it, At first I thought we will be clearing these old files later:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants