perf(wal): optimize torn write detection #21097
Conversation
…k to front Torn writes typically leave trailing zeros since the write operation is interrupted before completing. By checking sector chunks from back to front instead of front to back, we can detect torn entries faster in the common case where zeros appear at the end of the data
|
Hi @dxasu. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dxasu The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
2 participants
Torn writes typically leave trailing zeros since the write operation is interrupted before completing. By checking sector chunks from back to front instead of front to back, we can detect torn entries faster in the common case where zeros appear at the end of the data