Skip to content

Conversation

@ahrtr
Copy link
Member

@ahrtr ahrtr commented Jan 6, 2026

This is the first and the most important step to resolve #20187.

I will do a bootstrap performance comparison later.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr changed the title Set the consistent-index as the raft's Applied index [WIP] Set the consistent-index as the raft's Applied index Jan 7, 2026
@ahrtr ahrtr force-pushed the 20260106_bootstrap_v3_appliedid branch 2 times, most recently from 1b93da4 to 84ee3f0 Compare January 7, 2026 14:44
@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

❌ Patch coverage is 62.00000% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.39%. Comparing base (10838fc) to head (95c4c2d).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
server/etcdserver/bootstrap.go 66.66% 10 Missing and 2 partials ⚠️
server/etcdserver/api/membership/storev2.go 16.66% 5 Missing ⚠️
server/etcdserver/cindex/cindex.go 75.00% 2 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
server/etcdserver/cindex/cindex.go 89.65% <75.00%> (-2.80%) ⬇️
server/etcdserver/api/membership/storev2.go 58.82% <16.66%> (+5.88%) ⬆️
server/etcdserver/bootstrap.go 64.81% <66.66%> (+0.07%) ⬆️

... and 30 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #21091      +/-   ##
==========================================
- Coverage   68.44%   68.39%   -0.05%     
==========================================
  Files         429      429              
  Lines       35281    35321      +40     
==========================================
+ Hits        24147    24157      +10     
- Misses       9729     9754      +25     
- Partials     1405     1410       +5     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10838fc...95c4c2d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ahrtr ahrtr force-pushed the 20260106_bootstrap_v3_appliedid branch from 84ee3f0 to 95c4c2d Compare January 7, 2026 16:44
@k8s-ci-robot
Copy link

@ahrtr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-grpcproxy-integration-amd64 95c4c2d link true /test pull-etcd-grpcproxy-integration-amd64
pull-etcd-grpcproxy-integration-arm64 95c4c2d link true /test pull-etcd-grpcproxy-integration-arm64
pull-etcd-coverage-report 95c4c2d link true /test pull-etcd-coverage-report

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Bootstrap etcdserver from v3store (consistent_index)

2 participants