-
Notifications
You must be signed in to change notification settings - Fork 10.3k
[Robustness test] Implement RunWatchLoop for kubernetes traffic (part 3) #21076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Robustness test] Implement RunWatchLoop for kubernetes traffic (part 3) #21076
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: henrybear327 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 18 files with indirect coverage changes @@ Coverage Diff @@
## main #21076 +/- ##
==========================================
- Coverage 68.46% 68.44% -0.03%
==========================================
Files 429 429
Lines 35242 35242
==========================================
- Hits 24130 24120 -10
- Misses 9723 9735 +12
+ Partials 1389 1387 -2 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
323812d to
39f0369
Compare
39f0369 to
14a04c4
Compare
14a04c4 to
dd8fd43
Compare
2ae113d to
79a420e
Compare
79a420e to
c4ec9fa
Compare
c4ec9fa to
af5f435
Compare
|
Moving it out of the draft state to fix the CI error. Will ping @serathius when the PR is ready for a review pass! |
|
Please fix tests |
|
/retest |
2a58fff to
af5f435
Compare
b40b98b to
08bbf4d
Compare
08bbf4d to
41de3b0
Compare
41de3b0 to
7cd2844
Compare
Root cause: `RunWatchLoop()` spawned detached goroutines that were not tracked by the main `sync.WaitGroup`. When the parent `SimulateTraffic` is about to exit and calls `wg.Done()`, it will unblocked immediately, allowing Reports() to read from the history while detached goroutines were still writing to it since not all of them have been terminated. Signed-off-by: Chun-Hung Tseng <[email protected]>
Signed-off-by: Marek Siarkowicz <[email protected]> Signed-off-by: Chun-Hung Tseng <[email protected]>
|
Does this need to depend on #21139 ? |
7cd2844 to
4e2e557
Compare
actually yes, because of the RunWatchLoop would need to use the WaitGroup field, too. Please see https://github.com/etcd-io/etcd/pull/21076/changes#diff-d4d457da0a9114653db44aafe71d7888c5b0f7b7fce4a5d146c48783e14dc1bcR152 |
|
@henrybear327: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Implement
RunWatchLoopin Kubernetes traffic.Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.