Skip to content

fix cli option "--erase-flash" conflict with function erase_flash() #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2022
Merged

fix cli option "--erase-flash" conflict with function erase_flash() #103

merged 1 commit into from
Jul 11, 2022

Conversation

hfudev
Copy link
Member

@hfudev hfudev commented Jul 11, 2022

fix regression from #98

@hfudev hfudev self-assigned this Jul 11, 2022
@hfudev
Copy link
Member Author

hfudev commented Jul 11, 2022

@Ouss4 PTAL.

@hfudev
Copy link
Member Author

hfudev commented Jul 11, 2022

yanked 0.7.4

Ouss4
Ouss4 approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@Ouss4 Ouss4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah so it ended up conflicting with the function... I did have concerns that this may happen.
Thanks for the fix @hfudev.

@hfudev hfudev force-pushed the fix/erase_flash_cli_conflict_with_function branch from e11f9ff to 5a215c6 Compare July 11, 2022 09:16
@hfudev
Copy link
Member Author

hfudev commented Jul 11, 2022

added some tests

@hfudev hfudev merged commit bbd1512 into main Jul 11, 2022
@hfudev hfudev deleted the fix/erase_flash_cli_conflict_with_function branch August 23, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ouss4 Ouss4 Ouss4 approved these changes

Assignees

@hfudev hfudev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hfudev @Ouss4