feat(websocket): add WEBSOCKET_EVENT_HEADER_RECEIVED #827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryghtlabs-richard
force-pushed
the
feat/websocket-response-headers
branch
from
6be5991 to
f96e373
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -473,6 +479,8 @@ | |||
| .sub_protocol = client->config->subprotocol, | |||
| .user_agent = client->config->user_agent, | |||
| .headers = client->config->headers, | |||
| .header_hook = websocket_header_hook, | |||
Check failure
Code scanning / clang-tidy
field designator 'header_hook' does not refer to any field in type 'const esp_transport_ws_config_t' [clang-diagnostic-error] Error
There was a problem hiding this comment.
This is expected until ESP-IDF is updated to support header_hook and header_userp.
| @@ -473,6 +479,8 @@ | |||
| .sub_protocol = client->config->subprotocol, | |||
| .user_agent = client->config->user_agent, | |||
| .headers = client->config->headers, | |||
| .header_hook = websocket_header_hook, | |||
| .header_userp = client, | |||
Check failure
Code scanning / clang-tidy
field designator 'header_userp' does not refer to any field in type 'const esp_transport_ws_config_t' [clang-diagnostic-error] Error
Send a new event for each HTTP header-line received. Depends on espressif/esp-idf#16119 Closes espressif#715
bryghtlabs-richard
force-pushed
the
feat/websocket-response-headers
branch
from
f96e373 to
90cef3a
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Send a new event for each HTTP header-line received, so that the caller may extract interesting headers and cookies. In my case, this is needed for supporting F5 and Amazon ALB cookie-based load-balancers.
Related
Depends on espressif/esp-idf#16119
Closes #715
Testing
Confirmed I can print out the needed header-lines.
Checklist
Before submitting a Pull Request, please ensure the following: